Fix side effect import for pickleutil #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipykernel/pickleutil.py
Outdated
| @@ -10,6 +10,7 @@ | |||
| from types import FunctionType | |||
|
|
|||
| # This registers a hook when it's imported | |||
| from ipyparallel.serialize import codeutil # noqa: F401 | |||
There was a problem hiding this comment.
Does this make ipykernel depend on ipyparallel?
There was a problem hiding this comment.
It is listed as a test dependency, but yeah, we should add a guard.
blink1073
added a commit
to blink1073/ipykernel
that referenced
this pull request
Feb 29, 2024
(cherry picked from commit 384bdb1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is deprecated, but we should still keep it working on Windows.