Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add idle_timeout to routes #11

Merged
merged 2 commits into from
Jan 5, 2018
Merged

add idle_timeout to routes #11

merged 2 commits into from
Jan 5, 2018

Conversation

c0ze
Copy link
Contributor

@c0ze c0ze commented Jan 5, 2018 •
edited
Loading

Add idle_timeout to functions ui for hot functions.

related to iron-io/functions#663

currently doesn't work as it seems client is passing idle_timeout as string.

using type transformations, it seems ok.

@c0ze c0ze requested a review from kunihiko-t January 5, 2018 08:36
@c0ze c0ze changed the title [WIP] add idle_timeout to routes add idle_timeout to routes Jan 5, 2018
@c0ze
Copy link
Contributor Author

c0ze commented Jan 5, 2018

@kunihiko-t with the last commit, this seems ok ! Would appreciate if you could take a look !

kunihiko-t
kunihiko-t approved these changes Jan 5, 2018
View reviewed changes
Copy link

@kunihiko-t kunihiko-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I've tested via browser & checked actual route params with fn routes inspect command.
It works well :)

@c0ze
Copy link
Contributor Author

c0ze commented Jan 5, 2018

Thanks ! I'll merge this, but I don't know how to actually make a release for functions-ui. Let's see if some magic happens after merge :)

@c0ze c0ze merged commit c3492cc into master Jan 5, 2018
@c0ze c0ze mentioned this pull request Jan 26, 2018
Merged
@c0ze c0ze deleted the add-idle-timeout-to-routes branch January 28, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunihiko-t kunihiko-t kunihiko-t approved these changes

Assignees

@kunihiko-t kunihiko-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0ze @kunihiko-t