Introducing a ReclaimPolicy for ephemerally created Volume resource
#1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balpert89
reviewed
Nov 18, 2024
ushabelgur
commented
Nov 18, 2024
| @@ -36,6 +36,10 @@ func IsDefaultEphemeralControlledBy(o metav1.Object, owner metav1.Object) bool { | |||
| return metav1.IsControlledBy(o, owner) && IsEphemeralManagedBy(o, commonv1alpha1.DefaultEphemeralManager) | |||
| } | |||
|
|
|||
| func IsDefaultEphemeralOrControlledBy(o metav1.Object, owner metav1.Object) bool { | |||
| return metav1.IsControlledBy(o, owner) || IsEphemeralManagedBy(o, commonv1alpha1.DefaultEphemeralManager) | |||
There was a problem hiding this comment.
Note: I added new method with OR condition here, as above original method IsDefaultEphemeralControlledBy() is used by all other ephemeral controllers and it will break behavior of those controllers.
lukas016
force-pushed
the
osc/enh-volume-reclaim
branch
from
987deb1 to
c7fbc7e
Compare
lukas016
force-pushed
the
osc/enh-volume-reclaim
branch
from
c7fbc7e to
3eb6dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ReclaimPolicyfor ephemerally createdVolumeresource with 2 supported modes:Retain: the resource is not deleted after the managing resource has been deletedDelete: the current behavior, the resource is garbage-collected when the managing resource has been deletedReclaimPolicywould be assumed to beDeleteto not to not break current behavior.OwnerReferenceis added to ephemerally created volume only in case ofReclaimPolicyis set toDeleteVolumeTemplateSpecto supportReclaimPolicytype along with existing VolumeSpec[Note: volume_release_controller is already taking care of releasing volumes whose claimer doesn't existing, by setting .spec.claimRef to nil when claimer
Machineobject is deleted. So not adding any extra logic for this]Fixes #1114