Increase journal insertion speed #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsasha
force-pushed
the
faster-nrtm-insert
branch
2 times, most recently
from
7f372a5
to
bc2c9d4
Compare
As the journal table is locked per #685 anyways, we can guarantee that max(_new_serials_per_source) is the same as running MAX(serial_nrtm) per source after the first insert. The MAX(serial_nrtm) query is actually really slow, so avoiding this has significant benefits, and reduces the cost of locking the table.
mxsasha
force-pushed
the
faster-nrtm-insert
branch
from
bc2c9d4
to
96fe352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the journal table is locked per #685 anyways,
we can guarantee that max(_new_serials_per_source)
is the same as running MAX(serial_nrtm) per source
after the first insert.
The MAX(serial_nrtm) query is actually really slow,
so avoiding this has significant benefits, and
reduces the cost of locking the table.
This was extracted from #718 (c8209ba).