diff --git a/src/IsaacApiTypes.tsx b/src/IsaacApiTypes.tsx index bd97dbd6ab..17a5c28bc5 100644 --- a/src/IsaacApiTypes.tsx +++ b/src/IsaacApiTypes.tsx @@ -370,9 +370,6 @@ export interface InlineRegionValidationResponseDTO extends QuestionValidationRes } export interface LLMFreeTextQuestionValidationResponseDTO extends QuestionValidationResponseDTO { - markCalculationInstructions?: string; - additionalMarkingInstructions?: string; - maxMarks?: number; marksAwarded?: number; markBreakdown?: LLMFreeTextMarkSchemeEntryDTO[]; } diff --git a/src/app/components/content/IsaacQuestion.tsx b/src/app/components/content/IsaacQuestion.tsx index b76a4c34a3..465e921575 100644 --- a/src/app/components/content/IsaacQuestion.tsx +++ b/src/app/components/content/IsaacQuestion.tsx @@ -75,7 +75,6 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio const [hasSubmitted, setHasSubmitted] = useState(false); const hidingAttempts = useAppSelector(selectors.user.preferences)?.DISPLAY_SETTING?.HIDE_QUESTION_ATTEMPTS ?? false; - const {confidenceState, setConfidenceState, validationPending, setValidationPending, confidenceDisabled, recordConfidence, showQuestionFeedback} = useConfidenceQuestionsValues( currentGameboard?.tags?.includes("CONFIDENCE_RESEARCH_BOARD"), "question", @@ -169,7 +168,7 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio ; const possibleLLMFreeTextQuestionFeedbackView = isLLMFreeTextQuestion && showQuestionFeedback && validationResponse && showInlineAttemptStatus && !canSubmit ? - : + : null; return diff --git a/src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx b/src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx index 9cb9949262..fa0b76f818 100644 --- a/src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx +++ b/src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx @@ -13,11 +13,12 @@ const noFeedback = {disagree: false, partlyAgree: false, agree: false}; interface LLMFreeTextQuestionFeedbackViewProps { validationResponse: Immutable; + maxMarks: number; hasSubmitted: boolean; sentFeedback: boolean; setSentFeedback: (value: boolean) => void; } -export default function LLMFreeTextQuestionFeedbackView({validationResponse, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) { +export default function LLMFreeTextQuestionFeedbackView({validationResponse, maxMarks, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) { const dispatch = useAppDispatch(); const page = useAppSelector(selectors.doc.get); const accordion = useContext(AccordionSectionContext); @@ -40,7 +41,7 @@ export default function LLMFreeTextQuestionFeedbackView({validationResponse, has
- {`Prediction: ${validationResponse.marksAwarded} out of ${validationResponse.maxMarks} marks`} + {`Prediction: ${validationResponse.marksAwarded} out of ${maxMarks} marks`}