Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade foreground-child, remove unnecessary arg munging #123

Closed
wants to merge 3 commits into from
Closed

Upgrade foreground-child, remove unnecessary arg munging #123

wants to merge 3 commits into from

Commits on Jan 2, 2016

  1. Upgrade foreground-child, remove unnecessary arg munging 

    Foreground-child is now using cross-spawn-async in order to be able to
properly spawn shebangs and .cmd/.exe files.  This avoids the extra
cmd.exe that win-spawn throws into the mix, since that causes problems
when there is no PATH environ and a binary is being called explicitly
via a full path name.

Cross-spawn-async is a lot more code than win-spawn, but the approach it
takes is more surgical and well-tested.

Because of this, it's no longer necessary to unshift the node/io.js
binary onto the argument list when spawning a shebanged javascript file.
So, doing 'nyc mocha ...' on Windows will now work, and it's no longer
necessary to do 'nyc ./node_modules/mocha/bin/mocha.js ...' or any other
extra manual path munging.
    @isaacs
    isaacs committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    051b34d View commit details
    Browse the repository at this point in the history

  2. Don't include NYC_REQUIRE in the env if it's undefined 

    This was resulting in a opts.require=['undefined'] on Windows.
    @isaacs
    isaacs committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    3b8fbcb View commit details
    Browse the repository at this point in the history

  3. spawn-wrap@1.1.1

    @isaacs
    isaacs committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    f848577 View commit details
    Browse the repository at this point in the history