From c7512a845cd851ac5dded26b7938a86ea854d3e9 Mon Sep 17 00:00:00 2001 From: Vladimir Rudnyh Date: Thu, 15 Feb 2024 18:23:19 +0700 Subject: [PATCH 1/3] Update DVCx worker liveness probe command for k8s deployment --- charts/studio/templates/deployment-studio-dvcx-worker.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/charts/studio/templates/deployment-studio-dvcx-worker.yaml b/charts/studio/templates/deployment-studio-dvcx-worker.yaml index 7a537a9c..aa25d4df 100644 --- a/charts/studio/templates/deployment-studio-dvcx-worker.yaml +++ b/charts/studio/templates/deployment-studio-dvcx-worker.yaml @@ -73,10 +73,7 @@ spec: {{- end }} livenessProbe: exec: - command: - - python - - -c - - 'from viewer.utils import sqlalchemy_liveness_probe; sqlalchemy_liveness_probe()' + command: /app/bin/liveness-probe.sh initialDelaySeconds: 10 periodSeconds: 10 timeoutSeconds: 10 From 99b79688673eb0a98d69e56c9703a5aa95b9e747 Mon Sep 17 00:00:00 2001 From: Marcin Jasion Date: Mon, 19 Feb 2024 11:20:21 +0100 Subject: [PATCH 2/3] bump studio to the 2.93.1 which contain the new liveness probe check --- charts/studio/Chart.yaml | 4 ++-- charts/studio/README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/studio/Chart.yaml b/charts/studio/Chart.yaml index 533d1df4..db51ba86 100644 --- a/charts/studio/Chart.yaml +++ b/charts/studio/Chart.yaml @@ -2,8 +2,8 @@ apiVersion: v2 name: studio description: A Helm chart for Kubernetes type: application -version: 0.10.4 -appVersion: "v2.85.5" +version: 0.10.8 +appVersion: "v2.93.1" maintainers: - name: iterative email: support@iterative.ai diff --git a/charts/studio/README.md b/charts/studio/README.md index da97d2dd..26269310 100644 --- a/charts/studio/README.md +++ b/charts/studio/README.md @@ -1,6 +1,6 @@ # studio -![Version: 0.10.4](https://img.shields.io/badge/Version-0.10.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.85.5](https://img.shields.io/badge/AppVersion-v2.85.5-informational?style=flat-square) +![Version: 0.10.8](https://img.shields.io/badge/Version-0.10.8-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.93.1](https://img.shields.io/badge/AppVersion-v2.93.1-informational?style=flat-square) A Helm chart for Kubernetes From 3e584d06b5d413952045611624b2470c94f40f44 Mon Sep 17 00:00:00 2001 From: Marcin Jasion Date: Mon, 19 Feb 2024 11:49:55 +0100 Subject: [PATCH 3/3] Fix liveness probe commands --- .../studio/templates/deployment-studio-dvcx-worker.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/studio/templates/deployment-studio-dvcx-worker.yaml b/charts/studio/templates/deployment-studio-dvcx-worker.yaml index aa25d4df..3b627b22 100644 --- a/charts/studio/templates/deployment-studio-dvcx-worker.yaml +++ b/charts/studio/templates/deployment-studio-dvcx-worker.yaml @@ -48,7 +48,7 @@ spec: {{- toYaml .Values.studioDvcxWorker.securityContext | nindent 12 }} image: "{{ .Values.studioDvcxWorker.image.repository }}:{{ .Values.studioDvcxWorker.image.tag | default .Chart.AppVersion }}" imagePullPolicy: {{ .Values.studioDvcxWorker.image.pullPolicy }} - args: ["/app/bin/run_celery_worker_udf.sh"] + args: [ "/app/bin/run_celery_worker_udf.sh" ] resources: {{- toYaml .Values.studioDvcxWorker.resources | nindent 12 }} env: @@ -73,7 +73,7 @@ spec: {{- end }} livenessProbe: exec: - command: /app/bin/liveness-probe.sh + command: [ "/app/bin/liveness-probe.sh" ] initialDelaySeconds: 10 periodSeconds: 10 timeoutSeconds: 10 @@ -112,10 +112,10 @@ spec: storage: {{ .Values.studioDvcxWorker.ephemeralStorage.size }} {{- else if eq .Values.studioDvcxWorker.ephemeralStorage.type "pvc" }} persistentVolumeClaim: - claimName: {{ .Values.studioDvcxWorker.ephemeralStorage.persistentVolumeClaim.claimName }} + claimName: {{ .Values.studioDvcxWorker.ephemeralStorage.persistentVolumeClaim.claimName }} {{- else if eq .Values.studioDvcxWorker.ephemeralStorage.type "pvcRWX" }} persistentVolumeClaim: - claimName: {{.Release.Name}}-studio-dvcx-worker-ephemeral-rwx + claimName: {{.Release.Name}}-studio-dvcx-worker-ephemeral-rwx {{- else if eq .Values.studioDvcxWorker.ephemeralStorage.type "emptyDir"}} emptyDir: sizeLimit: {{ .Values.studioDvcxWorker.ephemeralStorage.size }}