From fa9e2b0c8405c05d197668dde7c3d48ad6fa8acd Mon Sep 17 00:00:00 2001 From: Matt Seddon Date: Wed, 10 Aug 2022 12:37:55 +1000 Subject: [PATCH] add ability to sort by starred status --- extension/src/experiments/index.ts | 4 +++- extension/src/experiments/model/sortBy/quickPick.ts | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/extension/src/experiments/index.ts b/extension/src/experiments/index.ts index 4133f1fe17..1bec430040 100644 --- a/extension/src/experiments/index.ts +++ b/extension/src/experiments/index.ts @@ -191,7 +191,9 @@ export class Experiments extends BaseRepository { public async addSort() { const columns = this.columns.getTerminalNodes() - const sortToAdd = await pickSortToAdd(columns) + const columnLikes = addStarredToColumns(columns) + + const sortToAdd = await pickSortToAdd(columnLikes) if (!sortToAdd) { return } diff --git a/extension/src/experiments/model/sortBy/quickPick.ts b/extension/src/experiments/model/sortBy/quickPick.ts index 4d4c74f1b4..9ccde4f998 100644 --- a/extension/src/experiments/model/sortBy/quickPick.ts +++ b/extension/src/experiments/model/sortBy/quickPick.ts @@ -3,10 +3,10 @@ import { definedAndNonEmpty } from '../../../util/array' import { quickPickManyValues, quickPickValue } from '../../../vscode/quickPick' import { Title } from '../../../vscode/title' import { Toast } from '../../../vscode/toast' +import { ColumnLike } from '../../columns/like' import { pickFromColumnLikes } from '../../columns/quickPick' -import { Column } from '../../webview/contract' -export const pickSortToAdd = async (columns: Column[]) => { +export const pickSortToAdd = async (columns: ColumnLike[] | undefined) => { const picked = await pickFromColumnLikes(columns, { title: Title.SELECT_PARAM_OR_METRIC_SORT })