Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent text from highlighting while resizing columns #2034

Closed
maxagin opened this issue Jul 15, 2022 · 6 comments · Fixed by #2214
Closed

Prevent text from highlighting while resizing columns #2034

maxagin opened this issue Jul 15, 2022 · 6 comments · Fixed by #2214
Assignees
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working priority-p1 Regular product backlog

Comments

@maxagin
Copy link
Contributor

maxagin commented Jul 15, 2022

Can we disable some styles when resizing the columns? and for similar cases: when the user works with something, other info blocks should not be affected.

Please think about similar cases and list them below. Thanks, folks!

Screen.Recording.2022-07-05.at.1.28.47.PM.mov
@maxagin maxagin added enhancement New feature or request A: experiments Area: experiments table webview and everything related labels Jul 15, 2022
@maxagin maxagin self-assigned this Jul 15, 2022
@shcheklein
Copy link
Member

@rogermparent I remember we were discussing this? Do we have a ticket for this by chance?

@shcheklein shcheklein added bug Something isn't working priority-p1 Regular product backlog and removed enhancement New feature or request discussion labels Jul 15, 2022
@rogermparent
Copy link
Contributor

You're right that we talked about it, but I couldn't find a ticket nor an item in any of the recent exp table stories

@rogermparent
Copy link
Contributor

Regarding the title, I think the solution to this specific problem will be more in the JS side like #1723 as opposed to styling, we don't want users to have these same highlights invisibly if we can help it

@rogermparent rogermparent changed the title Disable some styles when resizing the columns Prevent text from highlighting while resizing columns Jul 21, 2022
@maxagin
Copy link
Contributor Author

maxagin commented Jul 21, 2022

You're right that we talked about it, but I couldn't find a ticket nor an item in any of the recent exp table stories

This was a part of #1562
Thank you @rogermparent

@sroy3
Copy link
Contributor

sroy3 commented Aug 16, 2022

If I understand correctly the second task of #2040 ("Disable the value select option in all cells"). We simply remove the ability to select for the table and that would solve the resizing problem. I think that's fine as all cells have a copy button. All cells but the experiment name. Should we had a copy button for that cell as well? The other solution would be to disable selection only while resizing.

@sroy3 sroy3 self-assigned this Aug 16, 2022
@maxagin
Copy link
Contributor Author

maxagin commented Aug 18, 2022

The other solution would be to disable selection only while resizing.

I think this would work just fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working priority-p1 Regular product backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants