Simplify drag and drop integrations #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
requested review from
mattseddon,
rogermparent,
wolmir and
julieg18
as code owners
mattseddon
approved these changes
Aug 1, 2022
| @@ -26,16 +24,14 @@ export const Draggable: React.FC<DraggableProps> = ({ | |||
| disabled, | |||
| dropTarget, | |||
| onDrop, | |||
| onDragOver, | |||
| onDragEnter, | |||
| onDragStart | |||
| // eslint-disable-next-line sonarjs/cognitive-complexity | |||
There was a problem hiding this comment.
from the looks probably but thought I would check
There was a problem hiding this comment.
It passes sonar tests but not codeclimate. I checked.
|
Code Climate has analyzed commit a8c6a36 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1743
Would be quite hard to make just one integration after all. I didn't realize that the one for the experiments table does not work as a container since draggable items are deeply nested inside markup. What I was able to do though is to clean up that integration to use only what is necessary and not depend on the other integration (mainly the
makeTargetfunction).