Switch experiment sharing to progress api #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
use-progress-api
branch
from
67d2366 to
6883da3
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| export const getShareExperimentAsCommitCommand = | ||
| (internalCommands: InternalCommands) => | ||
| async (cwd: string, name: string, input: string) => { |
There was a problem hiding this comment.
Function getShareExperimentAsCommitCommand has 38 lines of code (exceeds 30 allowed). Consider refactoring.
mattseddon
force-pushed
the
use-progress-api
branch
from
6883da3 to
f9543f8
Compare
mattseddon
force-pushed
the
use-progress-api
branch
from
45c4a36 to
9468c84
Compare
mattseddon
force-pushed
the
use-progress-api
branch
from
9a59c99 to
51a3cc2
Compare
sroy3
approved these changes
Aug 24, 2022
|
Code Climate has analyzed commit 43366fe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the new experiment sharing commands over to use the progress API (instead of multiple toast popups).
Demo
Screen.Recording.2022-08-24.at.9.05.20.pm.mov
Note: Sample extension is here.