Fix styles of supported storage panels #4007
Conversation
| @@ -7,7 +7,7 @@ export const CloudVersioning: React.FC<PropsWithChildren> = ({ children }) => ( | |||
| <> | |||
| <InfoText> | |||
| <CloudVersioningLink /> requires {children} | |||
There was a problem hiding this comment.
children should probably be in a styled span that fixes the formatting problem rather than inserting newlines. Or maybe To enable run: should be inside its own p element.
There was a problem hiding this comment.
I missed a few \n in the previous review as well. We should not rely on them for styling / formatting, but rather use tags and css to do so.
| @@ -15,7 +15,7 @@ export const AzureBlobStorage = () => ( | |||
| <a href="https://learn.microsoft.com/en-us/azure/storage/blobs/versioning-overview"> | |||
| Blob versioning | |||
| </a>{' '} | |||
| enabled on the storage account and container. | |||
| enabled on the storage account{'\n'}and container.{' '} | |||
There was a problem hiding this comment.
Maybe it has been already discussed in a previous pr, but why are we adding these new lines in the first place? I'm not seeing the docs use new lines unless they're starting a new paragraph entirely.
Are we doing it to help emphasize certain lines? If so, maybe we should consider rewording text or using methods such as making keywords bold/italic?
mattseddon
force-pushed
the
add-shared-component
branch
from
f6c5d69 to
e02ed47
Compare
|
Code Climate has analyzed commit 71ecae9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
3/4
main<- #4005 <- #4006 <- this <- #4004This PR fixes the styles applied to the
<SupportedStorage />component.Demo
Screen.Recording.2023-05-30.at.1.51.11.pm.mov