Build TreeView for SortBy #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
rogermparent
added
A: experiments
- Split getChildren branches into methods - Await experiments for root - Turn getSort into getSorts (multi sorts not actually implemented)
This was referenced Jul 28, 2021
mattseddon
reviewed
Jul 28, 2021
mattseddon
approved these changes
Jul 29, 2021
mattseddon
approved these changes
Aug 9, 2021
|
Code Climate has analyzed commit 60cbee1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.4% change). View more on Code Climate. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi-sort-tree-demo.mp4
This PR adds a TreeView for viewing, adding, and removing sorts.
It also adds the ability for multiple sorts to be applied, as that's pretty inherent to the whole purpose of the tree such that most of its commands couldn't even be implemented without multi-sort.
This feature makes the assumption that users will only want one sort on any particular column, because the alternatives, sorting one direction and then the other or sorting in the same direction twice, don't really make any sense.
There's also a large sort tree integration test, which is really more of a general sorting integration test other than the fact it uses the table-specific sort commands alongside the more general ones.
The PR is pretty big, but most of the lines are tests, particularly ~300 from the new integration test.
Tasks for the future: