Golang version upgrade #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow test passed in my fork: https://github.com/camcast3/rcon-cli/actions/runs/9134257961/job/25119434978?pr=1 |
itzg
reviewed
May 18, 2024
| @@ -10,7 +10,7 @@ jobs: | |||
| release: | |||
| uses: itzg/github-workflows/.github/workflows/go-with-releaser-image.yml@main | |||
| with: | |||
| go-version: "1.20.10" | |||
| go-version: "1.21.10" | |||
There was a problem hiding this comment.
It was fixed in 1.20.11. Why bump the entire minor version?
There was a problem hiding this comment.
The first two in the list will be fixed by Golang v1.20.11.
However next 7 will be a longer term patch using +v1.21.9 so I used the latest stable in that minor version set
There was a problem hiding this comment.
I can move to 1.20.14 if you are more comfortable with that
There was a problem hiding this comment.
That all sounds good. I was focused on the major CVE item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing golang security vulns for stdlib v1.20.10 by upgrading to v1.21.10
Detected by docker scout
