From 6117b2471fb936aa14403aac3cac15120b6a32ba Mon Sep 17 00:00:00 2001 From: Benoit Sautel Date: Mon, 11 Jul 2016 11:03:43 +0200 Subject: [PATCH 1/2] Fix syntax warnings --- angular-imgcache.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/angular-imgcache.js b/angular-imgcache.js index 68172d4b..1cc62bef 100644 --- a/angular-imgcache.js +++ b/angular-imgcache.js @@ -9,17 +9,17 @@ angular.module('ImgCache', []) }, function() { ImgCache.$deferred.reject(); }); - } + }; this.manualInit = false; this.setOptions = function(options) { angular.extend(ImgCache.options, options); - } + }; this.setOption = function(name, value) { ImgCache.options[name] = value; - } + }; this.$get = ['$q', function ($q) { @@ -55,7 +55,7 @@ angular.module('ImgCache', []) el.attr('src', img_src); } }); - } + }; var loadImg = function(type, el, src) { @@ -73,7 +73,7 @@ angular.module('ImgCache', []) }); }); - } + }; attrs.$observe('icSrc', function(src) { From 741c1caa6d9ead6b07d55fd4a22d47323b807815 Mon Sep 17 00:00:00 2001 From: Benoit Sautel Date: Mon, 11 Jul 2016 11:10:03 +0200 Subject: [PATCH 2/2] Use non-cached image when it cannot be cached --- angular-imgcache.js | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/angular-imgcache.js b/angular-imgcache.js index 1cc62bef..10c4b751 100644 --- a/angular-imgcache.js +++ b/angular-imgcache.js @@ -44,16 +44,19 @@ angular.module('ImgCache', []) icSrc: '@' }, link: function(scope, el, attrs) { + var setImg = function(type, el, img_src) { + if (type === 'bg') { + el.css({'background-image': 'url(' + img_src + ')'}); + } else { + el.attr('src', img_src); + } + }; - var setImg = function(type, el, src) { + var setImgFromCache = function(type, el, src) { ImgCache.getCachedFileURL(src, function(src, dest) { var img_src = dest.fullPath.replace('/'. ImgCache.options.localCacheFolder, ImgCache.getCacheFolderURI()); - if(type === 'bg') { - el.css({'background-image': 'url(' + img_src + ')' }); - } else { - el.attr('src', img_src); - } + setImg(type, el, img_src); }); }; @@ -64,9 +67,11 @@ angular.module('ImgCache', []) ImgCache.isCached(src, function(path, success) { if (success) { - setImg(type, el, src); + setImgFromCache(type, el, src); } else { ImgCache.cacheFile(src, function() { + setImgFromCache(type, el, src); + }, function() { setImg(type, el, src); }); }