Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grpc is not running on the ui port #501

Merged
merged 2 commits into from
May 16, 2021
Merged

fix: grpc is not running on the ui port #501

merged 2 commits into from
May 16, 2021

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented May 15, 2021

Short description of the changes

all-in-one and jaeger-query do not, in fact, listen for grpc on the same port as http.

If you send grpc requests to this port, you get complete garbage back.

Do not tell people to use the wrong port.

% docker run -it jaegertracing/jaeger-query:1.22 --help  | fgrep -m1 grpc
      --query.grpc-server.host-port string              The host:port (e.g. 127.0.0.1:14250 or :14250) of the query's gRPC server (default ":16685")

Especially relevant as it segfaults if you look at it funny.

FauxFaux and others added 2 commits May 15, 2021 20:27
Signed-off-by: Chris West (Faux) <git@goeswhere.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I made the change in the next-release file as well.

However, there seem to be more placed that specify -p 16686:1668, they probably all need to be updated?

@yurishkuro
Copy link
Member

$ grx 16686:16686 content/docs/1.22
content/docs/1.22/getting-started.md:26:  -p 16686:16686 \
content/docs/1.22/deployment.md:170:  -p 16686:16686 \
content/docs/1.22/deployment.md:565:  -p 16686:16686 \
content/docs/1.22/monitoring.md:47:docker run -e JAEGER_DISABLED=true -p 16686:16686 jaegertracing/all-in-one:{{< currentVersion >}}

@FauxFaux
Copy link
Contributor Author

Elsewhere the all-in-one docs don't explain the grpc port (even though it's enabled), and don't expose it; just expose the one-ending-in-six, which actually is the UI port and is fine.

We could update all of the docs to tell you to expose all possible ports?

@yurishkuro yurishkuro merged commit 33168c3 into jaegertracing:master May 16, 2021
@FauxFaux FauxFaux deleted the patch-1 branch May 17, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants