diff --git a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.tsx b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.tsx index 68e84c5ac3..1e68909c9b 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.tsx +++ b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/DetailsPanel.tsx @@ -159,7 +159,7 @@ export class UnconnectedDetailsPanel extends React.PureComponent )} {this.state.detailsLoading && (
- +
)} {this.state.details && ( diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.tsx b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.tsx index a274fc981d..c146e0dc21 100644 --- a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.tsx +++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.tsx @@ -83,7 +83,7 @@ export class OperationTableDetails extends React.PureComponent { const { loading, error } = this.props; if (loading) { - return ; + return ; } if (error.opsCalls && error.opsErrors && error.opsLatencies) { diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/serviceGraph.tsx b/packages/jaeger-ui/src/components/Monitor/ServicesView/serviceGraph.tsx index ad008857f8..0e2f102292 100644 --- a/packages/jaeger-ui/src/components/Monitor/ServicesView/serviceGraph.tsx +++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/serviceGraph.tsx @@ -149,7 +149,7 @@ export class ServiceGraphImpl extends React.PureComponent { yAxisTickFormat, xDomain, } = this.props; - let GraphComponent = this.generatePlaceholder(); + let GraphComponent = this.generatePlaceholder(); const noDataComponent = this.generatePlaceholder('No Data'); const apiErrorComponent = this.generatePlaceholder('Couldn’t fetch data'); diff --git a/packages/jaeger-ui/src/components/QualityMetrics/index.tsx b/packages/jaeger-ui/src/components/QualityMetrics/index.tsx index 5f99a265cc..ae46516132 100644 --- a/packages/jaeger-ui/src/components/QualityMetrics/index.tsx +++ b/packages/jaeger-ui/src/components/QualityMetrics/index.tsx @@ -188,7 +188,7 @@ export class UnconnectedQualityMetrics extends React.PureComponent )} - {loading && } + {loading && } {error &&
{error.message}
} ); diff --git a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx index 282e1188e3..f5bbed3748 100644 --- a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx +++ b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx @@ -25,8 +25,7 @@ type LoadingIndicatorProps = { style?: React.CSSProperties; }; -export default function LoadingIndicator(props: LoadingIndicatorProps) { - const { centered, vcentered, className, small, ...rest } = props; +function LoadingIndicator({ centered, vcentered, className, small, ...rest }: LoadingIndicatorProps){ const cls = ` LoadingIndicator ${centered ? 'is-centered' : ''} @@ -37,8 +36,4 @@ export default function LoadingIndicator(props: LoadingIndicatorProps) { return ; } -LoadingIndicator.defaultProps = { - centered: false, - className: undefined, - small: false, -}; +export default LoadingIndicator \ No newline at end of file