-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support uploads of .jsonl files #2461
Support uploads of .jsonl files #2461
Conversation
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
@yurishkuro do we need to consider any other scenario while accepting jsonl files by default? |
Thanks! |
tests are failing, you need to rebuild the snapshot |
Signed-off-by: Saumyacodes-40 <saumyabshah90@gmail.com>
Head branch was pushed to by a user without write access
updated! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 254 254
Lines 7679 7679
Branches 1931 1982 +51
=======================================
Hits 7419 7419
Misses 260 260 ☔ View full report in Codecov by Sentry. |
Which problem is this PR solving?
Fixes #2458
Description of the changes
How was this change tested?
Uploading jsonl files through drag and drop
Clicking upload button which was able to detect support for jsonl files
I'd tested against this input
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test