Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph visualisation works with sub-second units #986

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Sep 5, 2022

Signed-off-by: pavelpashkovsky pavelpashkovsky@gmail.com

Which problem is this PR solving?

Short description of the changes

  • bump @pyroscope/flamegraph
    image

Signed-off-by: pavelpashkovsky <pavelpashkovsky@gmail.com>
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Base: 95.44% // Head: 95.47% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (fc6263d) compared to base (a7b2386).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   95.44%   95.47%   +0.02%     
==========================================
  Files         243      243              
  Lines        7560     7560              
  Branches     1892     1892              
==========================================
+ Hits         7216     7218       +2     
+ Misses        337      335       -2     
  Partials        7        7              
Impacted Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 94.44% <0.00%> (-5.56%) ⬇️
...mponents/TracePage/TraceStatistics/tableValues.tsx 98.62% <0.00%> (+1.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: pavelpashkovsky <pavelpashkovsky@gmail.com>
@pavelpashkovsky pavelpashkovsky changed the title Flamegraph visualisation works with sub-second units [WIP] Flamegraph visualisation works with sub-second units Sep 5, 2022
@pavelpashkovsky pavelpashkovsky marked this pull request as ready for review September 5, 2022 15:34
Signed-off-by: pavelpashkovsky <pavelpashkovsky@gmail.com>
@yurishkuro yurishkuro merged commit bbe7b3f into jaegertracing:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants