If --agent.tags or other tags are mal-formed, display the invalid val…

…ue as part of the panic Signed-off-by: Ed Snible <snible@us.ibm.com>
jaegertracing · Sep 3, 2021 · 0bc7985 · 0bc7985
1 parent 27fe841
commit 0bc7985
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/cmd/flags/flags.go b/cmd/flags/flags.go
@@ -58,6 +58,9 @@ func ParseJaegerTags(jaegerTags string) map[string]string {
 	tags := make(map[string]string)
 	for _, p := range tagPairs {
 		kv := strings.SplitN(p, "=", 2)
+		if len(kv) != 2 {
+			panic(fmt.Sprintf("invalid Jaeger tag pair %q, expected key=value", p))
+		}
 		k, v := strings.TrimSpace(kv[0]), strings.TrimSpace(kv[1])
 
 		if strings.HasPrefix(v, "${") && strings.HasSuffix(v, "}") {