adds return obj to handler

jaegertracing · Jul 10, 2023 · 64a6fdf · 64a6fdf
1 parent 62b8c5a
commit 64a6fdf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/examples/hotrod/pkg/tracing/http.go b/examples/hotrod/pkg/tracing/http.go
@@ -46,7 +46,6 @@ func (c *HTTPClient) GetJSON(ctx context.Context, url string, out interface{}) e
 	if err != nil {
 		return err
 	}
-	req = req.WithContext(ctx)
 
 	res, err := c.Client.Do(req)
 	if err != nil {

diff --git a/examples/hotrod/pkg/tracing/mux.go b/examples/hotrod/pkg/tracing/mux.go
@@ -47,7 +47,7 @@ type TracedServeMux struct {
 func (tm *TracedServeMux) Handle(pattern string, handler http.Handler) {
 	tm.logger.Bg().Debug("registering traced handler", zap.String("endpoint", pattern))
 
-	otelhttp.WithRouteTag(pattern, handler)
+	handler = otelhttp.WithRouteTag(pattern, handler)
 
 	middleware := otelhttp.NewHandler(handler, pattern,
 		otelhttp.WithTracerProvider(tm.tracer))