Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default logging shouldn't be sampled #160

Closed
vprithvi opened this issue May 12, 2017 · 5 comments
Closed

Default logging shouldn't be sampled #160

vprithvi opened this issue May 12, 2017 · 5 comments
Labels
bug good first issue Good for beginners

Comments

@vprithvi
Copy link
Contributor

Logs are sampled, and any more than ~100 logs lines per second would be dropped.
Change this so that all logs are output.

@jpkrohling
Copy link
Contributor

Is this still the case?

@jpkrohling jpkrohling added the bug label Apr 2, 2019
@yurishkuro
Copy link
Member

that's the default in zap, so probably still an issue

@jpkrohling
Copy link
Contributor

Looks like we just need to find the places we call zap.NewProductionConfig() and set its Sampling property to nil:

https://github.com/uber-go/zap/blob/badef736563f8135e0add3232b06f58656da03c8/config.go#L68-L69

Looks like a good first issue to me :-)

@jpkrohling jpkrohling added the good first issue Good for beginners label Apr 4, 2019
@psinghal20
Copy link
Contributor

Hi! If this issue is still up for grabs, I would love to work on this.

@jpkrohling
Copy link
Contributor

@psinghal20 it's yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners
Projects
None yet
Development

No branches or pull requests

4 participants