Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badger index merge is working incorrectly #1719

Closed
burmanm opened this issue Aug 8, 2019 · 0 comments · Fixed by #1721
Closed

Badger index merge is working incorrectly #1719

burmanm opened this issue Aug 8, 2019 · 0 comments · Fixed by #1721
Labels
storage/badger Issues related to badger storage

Comments

@burmanm
Copy link
Contributor

burmanm commented Aug 8, 2019

Problem - what in Jaeger blocks you from solving the requirement?

While doing some additional tests, I managed to create a case where the end result that used multiple index queries was not correct.

Merge-join processing has bugs.

  • Missing one advance in the equality compare
  • Input for the next round should be the output of previous invocation (in same sorted order)

Proposal - what do you suggest to solve the problem or improve the existing situation?

Working on it, adding also some more tests also to verify more complex index merge scenarios.

burmanm added a commit to burmanm/jaeger that referenced this issue Aug 8, 2019
burmanm added a commit to burmanm/jaeger that referenced this issue Aug 9, 2019
@pavolloffay pavolloffay added the storage/badger Issues related to badger storage label Aug 9, 2019
pavolloffay pushed a commit that referenced this issue Aug 19, 2019
* Fix merge-join algorithm to correctly filter indexes, closes #1719

Signed-off-by: Michael Burman <yak@iki.fi>

* Address comments

Signed-off-by: Michael Burman <yak@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage/badger Issues related to badger storage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants