-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suport for collector level tags #1844
Comments
if we do this, let's make sure we reuse the code from the agent |
@yurishkuro, would the referenced commit be close to what you'd imagine such a feature to look like? It would obviously require tests. For clarity, this is not a PR yet. |
@yurishkuro I've opened the PR so the work can be tracked. I'll add tests in the next couple of days. Regarding #1788, I wonder what's the best way to proceed. Probably wait for that to be merged first and then adapt my PR? Edit: alternative would be to have this merged with unit tests in and then adapt #1788 to take collector tags into account in a single swipe. |
Yes, you're probably right, we can merge #1854 first, and then add the deduping policy as a separate ticket. |
Signed-off-by: radekg <radek@gruchalski.com>
Signed-off-by: radekg <radek@gruchalski.com>
Similar to agent tags #833
Related to removing duplicated tags in collector #1778
Add the ability to the collector to add a set of tags to incoming spans.
The agent supports
JAEGER_TAGS
for adding tags, however if we support the same env var in collector the same set of tags could be added twice - although it depends if we remove duplicate tags in #1778.Use cases:
The text was updated successfully, but these errors were encountered: