Configurable kafka protocol version for msg consuming by jaeger ingester

[marqc]

Which problem is this PR solving?

Jaeger ingester silently doesn't consume messages, when kafka server doesn't support kafka protocol in version 0.0.9.

Short description of the changes

I added new kafka.consumer.protocol-version configuration option, that allows specify kafka protocol version to use. Default is "0.9.0.0" which was used by bsm/sarama-cluster as default version (for backwards compatibility).

[codecov]

Codecov Report

Merging #1640 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   98.71%   98.71%   +<.01%     
==========================================
  Files         193      193              
  Lines        9228     9233       +5     
==========================================
+ Hits         9109     9114       +5     
  Misses         91       91              
  Partials       28       28

Impacted Files	Coverage Δ
cmd/ingester/app/flags.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c8e56...12c3221. Read the comment docs.

[yurishkuro]

tests are failing

--- FAIL: TestOptionsWithFlags (0.00s)
    flags_test.go:46: 
        	Error Trace:	flags_test.go:46
        	Error:      	Not equal: 
        	            	expected: "1.0.0"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-1.0.0
        	            	+
        	Test:       	TestOptionsWithFlags
    flags_test.go:47: 
        	Error Trace:	flags_test.go:47
        	Error:      	Not equal: 
        	            	expected: 5
        	            	actual  : 1000
        	Test:       	TestOptionsWithFlags
    flags_test.go:48: 
        	Error Trace:	flags_test.go:48
        	Error:      	Not equal: 
        	            	expected: 120000000000
        	            	actual  : 60000000000
        	Test:       	TestOptionsWithFlags

[marqc]

@yurishkuro I made a typo in test data config. Fixed now.

[yurishkuro]

Q: wouldn't a symmetric change in producer code make sense as well?

[marqc]

Q: wouldn't a symmetric change in producer code make sense as well?

Yes. Good point. I can prepare some PR for cmd/collector pkg/kafka/producer tomorrow