Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector kafka producer protocol version config #1658

Conversation

marqc
Copy link
Contributor

@marqc marqc commented Jul 9, 2019

Which problem is this PR solving?

  • Configure kafka server version in client. When kafka server has disabled backwards compatibility with older versions it may cause collector failure, because sarama by default uses oldest supported version.

Short description of the changes

Chodor Marek and others added 4 commits July 1, 2019 10:09
Signed-off-by: Chodor Marek <marek.chodor@grupawp.pl>
…onfig

Signed-off-by: Chodor Marek <marek.chodor@grupawp.pl>
Signed-off-by: Chodor Marek <marek.chodor@grupawp.pl>
Signed-off-by: Chodor Marek <marek.chodor@grupawp.pl>
@marqc marqc force-pushed the collector_kafka_producer_protocol_version_config branch from 9a90ad7 to caf0760 Compare July 9, 2019 08:35
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #1658 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   98.71%   98.71%   +<.01%     
==========================================
  Files         193      193              
  Lines        9233     9238       +5     
==========================================
+ Hits         9114     9119       +5     
  Misses         91       91              
  Partials       28       28
Impacted Files Coverage Δ
plugin/storage/kafka/options.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14b096...f97c7bd. Read the comment docs.

Signed-off-by: Chodor Marek <marek.chodor@grupawp.pl>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 035fb77 into jaegertracing:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants