Fix ordering of indexScanKeys after TraceID parsing, closes #1808 #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
burmanm
force-pushed
the
badger_bug_1808
branch
2 times, most recently
from
80c5768
to
02b3cb7
Compare
…cing#1808 Signed-off-by: Michael Burman <yak@iki.fi>
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
+ Coverage 98.21% 98.21% +<.01%
==========================================
Files 195 195
Lines 9602 9606 +4
==========================================
+ Hits 9431 9435 +4
Misses 134 134
Partials 37 37
Continue to review full report at Codecov.
|
objectiser
reviewed
Sep 25, 2019
Signed-off-by: Michael Burman <yak@iki.fi>
objectiser
reviewed
Sep 30, 2019
objectiser
approved these changes
Sep 30, 2019
yurishkuro
requested changes
Oct 1, 2019
|
@yurishkuro Think your comment has been addressed - is it ok to merge? |
yurishkuro
approved these changes
Oct 9, 2019
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
…cing#1808 (jaegertracing#1809) * Fix ordering of indexScanKeys after TraceID parsing, closes jaegertracing#1808 Signed-off-by: Michael Burman <yak@iki.fi> * Address comments Signed-off-by: Michael Burman <yak@iki.fi> * .. Signed-off-by: Michael Burman <yak@iki.fi> Signed-off-by: radekg <radek@gruchalski.com>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
…cing#1808 (jaegertracing#1809) * Fix ordering of indexScanKeys after TraceID parsing, closes jaegertracing#1808 Signed-off-by: Michael Burman <yak@iki.fi> * Address comments Signed-off-by: Michael Burman <yak@iki.fi> * .. Signed-off-by: Michael Burman <yak@iki.fi> Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Bug #1808
indexSeeksToTraceIDsreturns keys in wrong order after parsing the TraceID, whiledurationQueriesreturned them in correct order.Short description of the changes
Add slice sorting after TraceID parsing to ensure the order is correct. Also add read-order test for this method.