Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom port in cassandra schema creation #2472

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

MarianZoll
Copy link
Contributor

what:

  • considered CQLSH_PORT in schema creation port
    why:
  • unable to create schema in Cassandra instances not exposing 9042

Signed-off-by: Marian Zoll Marian.Zoll@web.de

Which problem is this PR solving?

Fixes #2467

Short description of the changes

  • Added support for CQLSH_PORT in docker.sh for schema creations.

what:
- considered CQLSH_PORT in schema creation port
why:
- unable to create schema in Cassandra instances not exposing 9042

Signed-off-by: Marian Zoll <Marian.Zoll@web.de>
@MarianZoll MarianZoll requested a review from a team as a code owner September 11, 2020 14:48
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #2472 into master will decrease coverage by 0.03%.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
- Coverage   95.58%   95.54%   -0.04%     
==========================================
  Files         208      208              
  Lines       10679    10750      +71     
==========================================
+ Hits        10207    10271      +64     
- Misses        399      404       +5     
- Partials       73       75       +2     
Impacted Files Coverage Δ
ports/ports.go 100.00% <ø> (ø)
cmd/query/app/server.go 90.69% <96.29%> (-0.42%) ⬇️
cmd/query/app/flags.go 100.00% <100.00%> (ø)
plugin/storage/es/dependencystore/storage.go 90.74% <100.00%> (+0.17%) ⬆️
plugin/storage/es/factory.go 100.00% <100.00%> (ø)
plugin/storage/es/options.go 100.00% <100.00%> (ø)
plugin/storage/es/spanstore/reader.go 100.00% <100.00%> (ø)
plugin/storage/es/spanstore/service_operation.go 100.00% <100.00%> (ø)
plugin/storage/grpc/shared/grpc_client.go 85.96% <100.00%> (ø)
cmd/agent/app/reporter/grpc/builder.go 95.45% <0.00%> (-4.55%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393e04d...be8af75. Read the comment docs.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested this locally and confirmed it worked.

@yurishkuro yurishkuro changed the title Fix port in cassandra schema creation Support custom port in cassandra schema creation Sep 12, 2020
@yurishkuro yurishkuro merged commit 9ebdb48 into jaegertracing:master Sep 12, 2020
mergify bot pushed a commit to jaegertracing/jaeger-operator that referenced this pull request Oct 12, 2020
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>

Since jaegertracing/jaeger#2472 is merged, adding support for custom port here.

Partially Fixes: #1179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PaaS Cassandra - Add Port
3 participants