Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel] Update jaeger-lib to v2.4.0 #2538

Merged
merged 2 commits into from
Oct 5, 2020
Merged

[otel] Update jaeger-lib to v2.4.0 #2538

merged 2 commits into from
Oct 5, 2020

Conversation

dstdfx
Copy link
Contributor

@dstdfx dstdfx commented Oct 5, 2020

In addition to #2496

@dstdfx
Update jaeger-lib to v2.4.0
c378563 
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
@dstdfx dstdfx requested a review from a team as a code owner October 5, 2020 19:52
@dstdfx
Copy link
Contributor Author

dstdfx commented Oct 5, 2020

cc @yurishkuro

@dstdfx
Clean deps by go mod tidy
f5cc039 
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #2538 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2538      +/-   ##
==========================================
+ Coverage   95.32%   95.33%   +0.01%     
==========================================
  Files         208      208              
  Lines        9248     9248              
==========================================
+ Hits         8816     8817       +1     
+ Misses        355      354       -1     
  Partials       77       77
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe84288...f5cc039. Read the comment docs.

yurishkuro
yurishkuro approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 1d37ebc into jaegertracing:master Oct 5, 2020
@dstdfx dstdfx deleted the otel-deps branch October 28, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstdfx @yurishkuro