Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log problems communicating with Elasticsearch #3451

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

esnible
Copy link
Contributor

@esnible esnible commented Dec 15, 2021

Signed-off-by: Ed Snible snible@us.ibm.com

Log problems talking to ElasticSearch.

Inspired by #3443

In the case tested, Jaeger v3 API returns a 500 error to the client with no log for the maintainers. A server shouldn't return a 500 error, thus it is worth logging when we do.

I considered adding logic to deal with #3443 by validating the request and not sending it to ElasticSearch, but I am not ready to do that. I will follow up on the Issue.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from a team as a code owner December 15, 2021 14:54
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #3451 (da94fe6) into main (5ea0544) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   96.47%   96.45%   -0.02%     
==========================================
  Files         262      262              
  Lines       15307    15308       +1     
==========================================
- Hits        14768    14766       -2     
- Misses        456      458       +2     
- Partials       83       84       +1     
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100.00% <100.00%> (ø)
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea0544...da94fe6. Read the comment docs.

@yurishkuro yurishkuro enabled auto-merge (squash) December 15, 2021 15:01
@yurishkuro yurishkuro merged commit 576266f into jaegertracing:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants