Log problems communicating with Elasticsearch #3451
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Snible snible@us.ibm.com
Log problems talking to ElasticSearch.
Inspired by #3443
In the case tested, Jaeger v3 API returns a 500 error to the client with no log for the maintainers. A server shouldn't return a 500 error, thus it is worth logging when we do.
I considered adding logic to deal with #3443 by validating the request and not sending it to ElasticSearch, but I am not ready to do that. I will follow up on the Issue.