-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SBOM file and pointer in README.md #3953
Conversation
Signed-off-by: jkowall <jkowall@kowall.net>
Codecov ReportBase: 97.14% // Head: 97.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 295 295
Lines 17389 17389
=======================================
Hits 16893 16893
Misses 399 399
Partials 97 97 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is this a good practice to publish a one-off SBOM? I would think it needs to be produced during the build process and maybe included in the github release page. |
This is what Pixie is doing, but other projects have integrated the syft gh action into their release flow. I was going to do that, but this seemed like an easy fix. An example of a syft integration for a CNCF project is here: https://github.com/artifacthub/hub/blob/master/.github/workflows/release.yml I am not confident how to test the build process really even after reading the docs, if I can do that on a fork, so I opted for the easy path for the SBOM. |
Have you already thought to use https://github.com/CycloneDX/gh-gomod-generate-sbom ? |
@jkowall the full build of binaries is just running a shell script, it can be tested locally. Uploading the file to release is probably harder to test from a fork, but that's done by a GH action and you just need to add the glob for the file (see .github/workflows/ci-release.yml) |
Signed-off-by: jkowall <jkowall@kowall.net>
Signed-off-by: jkowall <jkowall@kowall.net>
If you want to take a look, I tried it here : https://github.com/mmorel-35/jaeger/actions/runs/3207214623 |
@mmorel-35 Feel free to contribute you know the GH actions better than I do :) |
This PR should fix up several items around #3943 |
Removing sbom since we are going with the generated one during the build. Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: jkowall jkowall@kowall.net
Which problem is this PR solving?
Resolves the lack of SBOM for Jaeger project
Short description of the changes
Added .json and pointer. This is generated from syft via the all-in-one docker image
syft jaegertracing/all-in-one:1.38 -o json > jaeger-sbom.json
This will help us fix gaps in our security setup per : https://clomonitor.io/projects/cncf/jaeger#jaeger_security