-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate and publish sbom on release #3956
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Codecov ReportBase: 97.14% // Head: 97.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
==========================================
- Coverage 97.14% 97.12% -0.03%
==========================================
Files 295 295
Lines 17389 17389
==========================================
- Hits 16893 16889 -4
- Misses 399 402 +3
- Partials 97 98 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for doing this! I can add the link to Readme after. |
This will only publish SBOM for Go code. We also have UI code, and the content of the base Docker images.
|
That's why I just used Syft on the base all-in-one image, which should get us where we need to be. This seems like a one-time thing, since we don't add a huge amount of code and libraries to the project at this point. Probably over-engineering it to build it into the pipeline. Most folks who really need to track libraries in projects will use a service like Snyk, Whitesource, etc they will not just rely on a file published in a project. I considered this work as a box checking exercise. |
I don't think so - we have dependabot enabled and update dependencies constantly, so the one-off SBOM will be out of date usually by the next release. If we can't automate it, I'd rather not publish SBOM at all than publish a misleading one. E.g. this year, 92 dependency bumps (not counting manual ones), ie.. 2-3 times a week on average:
|
Done in #3987 |
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com
Which problem is this PR solving?
Short description of the changes