Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose otel configured thrift http port #3986

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh see.kwang.teoh@gmail.com

Which problem is this PR solving?

Short description of the changes

  • A support question was submitted to provide an example where a Python application's R.E.D metrics can be visualised based just on the spans it emits.
  • I had considered creating a new repo that brings up the components required for SPM, but realised it's almost exactly the same as the SPM dev environment in jaeger, just with microsim removed, and most importantly, exposing the port listened on by OTEL's jaeger receiver on port 14278.
  • The simpler option is just to expose the above port from within this dev environment, which also opens the opportunity for any other local application to emit spans to, to view their own R.E.D metrics.

Testing

With a custom simple Python script that generates a 3-tiered trace on service my_service and emits them to localhost:14278, the R.E.D metrics are visible in Jaeger SPM:

Screen Shot 2022-10-19 at 9 54 46 pm

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner October 19, 2022 10:56
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 97.15% // Head: 97.16% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c372522) compared to base (64f9699).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3986      +/-   ##
==========================================
+ Coverage   97.15%   97.16%   +0.01%     
==========================================
  Files         295      295              
  Lines       17389    17389              
==========================================
+ Hits        16894    16896       +2     
+ Misses        399      397       -2     
  Partials       96       96              
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -23,6 +23,8 @@ services:
volumes:
- "./otel-collector-config.yml:/etc/otelcol/otel-collector-config.yml"
command: --config /etc/otelcol/otel-collector-config.yml
ports:
- "14278:14278"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should there be that many ports exposed from all-in-one? It seems in this setup all collection should go through OTEL collector.
  2. May be useful to explain this in the readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @yurishkuro, good points. I'll address them in a follow-up PR.

@albertteoh albertteoh merged commit eaed620 into jaegertracing:main Oct 20, 2022
@albertteoh albertteoh deleted the expose-traces-http-port branch October 20, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants