Respect the same SRI checks that HWP supports via webpack-subresource-integrity #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eliperelman thanks for this. looks good, but I know little about it. Is there a link to the HWP doc about this feature that you could point me to for some quick education pre-merge? |
|
Sure! The issue on HWP is: jantimon/html-webpack-plugin#330 Which led to the creation of: https://github.com/waysact/webpack-subresource-integrity If you currently use the webpack-subresource-integrity plugin with HWT, no integrity data is added to assets. |
|
Thanks for the link! Looks great. |
|
Thank you for the merge! Note that I think the approach in #61 would be a good idea for avoiding PRs like this in the future. 👍 |
|
Noted, thanks!
…On Tue, Oct 24, 2017 at 2:23 PM, Eli Perelman ***@***.***> wrote:
Thank you for the merge! Note that I think the approach in #61
<#61> would be a
good idea for avoiding PRs like this in the future. 👍
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhsbCFn1-Y74cYxTmuHmnri8jSAaQMNks5svkdcgaJpZM4P3rqs>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html-webpack-plugin respects crossorigin and integrity attributes set on chunks via the webpack-subresource-integrity plugin. This PR attempts to support this as well by adding those attributes to script and link tags which can have integrity attributes.