Upgrade to Bevy 0.15 #221
Merged
Upgrade to Bevy 0.15 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not quite working though 🚧
Vrixyz
force-pushed
the
bevy_0.15
branch
2 times, most recently
from
a00cec9 to
335d678
Compare
Vrixyz
force-pushed
the
bevy_0.15
branch
2 times, most recently
from
f64d1af to
645eb99
Compare
jakobhellermann
requested changes
Nov 6, 2024
Comment on lines
1023
to
1024
| // TODO: display error ? Is entering here even possible ? | ||
| continue; |
There was a problem hiding this comment.
uhhh... this is an edge case in an edge case but I think I would just return None here as well, since this for loop should only work if you're multi-editing a bunch of Handles
There was a problem hiding this comment.
maybe a warn! would be interesting 🤔
crates/bevy-inspector-egui/src/inspector_options/default_options.rs
Outdated
Show resolved
Hide resolved
8 tasks
7 tasks
Vrixyz
commented
Nov 8, 2024
Vrixyz
commented
Nov 8, 2024
3 tasks
|
bevy_egui now has a release for 0.15. And add #224 as solvable by this PR |
jakobhellermann
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose to rely mostly on
PartialReflect, even though I imagine in practice everything isReflect; I'm not sure it's possible to rely onReflectexclusively because when we're cloning the value, errors are handled in another function.I imagine we could either unwrap, or bubble the errors up, but I fear that would make a lot of changes for not much benefits ; also, I believe relaxing trait bounds is always interesting.