Skip to content

Refactor proxy

Refactor proxy #1619

Triggered via pull request September 24, 2024 10:34
Status Success
Total duration 49s
Artifacts

clippy.yml

on: pull_request
check-rust-clippy
38s
check-rust-clippy
Fit to window
Zoom out
Zoom in

Annotations

31 warnings
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `avoid_weird_mac_bug` is never used: plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used --> plane/plane-tests/tests/common/resources/pebble.rs:193:14 | 193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: plane/src/proxy/cert_pair.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler --> plane/src/proxy/cert_pair.rs:79:38 | 79 | let key = any_supported_type(&key)?; | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
used `unwrap()` on a `Result` value: plane/src/proxy/proxy_server.rs#L95
warning: used `unwrap()` on a `Result` value --> plane/src/proxy/proxy_server.rs:95:21 | 95 | upgrade_handler.run().await.unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on a `Result` value: plane/src/proxy/proxy_server.rs#L86
warning: used `unwrap()` on a `Result` value --> plane/src/proxy/proxy_server.rs:86:42 | 86 | let (res, upgrade_handler) = inner.proxy_client.request(request).await.unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on a `Result` value: plane/src/proxy/proxy_server.rs#L70
warning: used `unwrap()` on a `Result` value --> plane/src/proxy/proxy_server.rs:70:29 | 70 | request.parts.uri = Uri::from_parts(uri_parts).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on a `Result` value: plane/src/proxy/proxy_server.rs#L64
warning: used `unwrap()` on a `Result` value --> plane/src/proxy/proxy_server.rs:64:38 | 64 | return Box::pin(ready(Ok(Response::builder() | ______________________________________^ 65 | | .status(StatusCode::UNAUTHORIZED) 66 | | .body(simple_empty_body()) 67 | | .unwrap()))); | |_________________________^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used note: the lint level is defined here --> plane/src/lib.rs:1:9 | 1 | #![warn(clippy::unwrap_used)] | ^^^^^^^^^^^^^^^^^^^
this expression creates a reference which is immediately dereferenced by the compiler: plane/src/proxy/cert_pair.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler --> plane/src/proxy/cert_pair.rs:79:38 | 79 | let key = any_supported_type(&key)?; | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
function `subdomain_from_host` is never used: plane/src/proxy/request.rs#L14
warning: function `subdomain_from_host` is never used --> plane/src/proxy/request.rs:14:8 | 14 | pub fn subdomain_from_host<'a>( | ^^^^^^^^^^^^^^^^^^^
constant `HTTPS_PORT_SUFFIX` is never used: plane/src/proxy/request.rs#L8
warning: constant `HTTPS_PORT_SUFFIX` is never used --> plane/src/proxy/request.rs:8:7 | 8 | const HTTPS_PORT_SUFFIX: &str = ":443"; | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
check-rust-clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check-rust-clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/