Refactor proxy #1633
Annotations
30 warnings
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
function `avoid_weird_mac_bug` is never used:
plane/plane-tests/tests/common/resources/pebble.rs#L193
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
used `unwrap()` on a `Result` value:
plane/src/proxy/proxy_server.rs#L193
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:193:24
|
193 | let mut response = Response::builder()
| ________________________^
194 | | .status(status_code)
195 | | .body(simple_empty_body())
196 | | .unwrap();
| |_________________^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
plane/src/proxy/proxy_server.rs#L118
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:118:17
|
118 | HeaderValue::from_str(&route_info.backend_id.to_string()).unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
plane/src/proxy/proxy_server.rs#L104
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:104:21
|
104 | upgrade_handler.run().await.unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
plane/src/proxy/proxy_server.rs#L94
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:94:46
|
94 | let (mut res, upgrade_handler) = inner.proxy_client.request(request).await.unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
|
used `unwrap()` on a `Result` value:
plane/src/proxy/proxy_server.rs#L76
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:76:29
|
76 | request.parts.uri = Uri::from_parts(uri_parts).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> plane/src/lib.rs:1:9
|
1 | #![warn(clippy::unwrap_used)]
| ^^^^^^^^^^^^^^^^^^^
|
this expression creates a reference which is immediately dereferenced by the compiler:
plane/src/proxy/cert_pair.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane/src/proxy/cert_pair.rs:79:38
|
79 | let key = any_supported_type(&key)?;
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
plane/src/proxy/cert_pair.rs#L79
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane/src/proxy/cert_pair.rs:79:38
|
79 | let key = any_supported_type(&key)?;
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
check-rust-clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
check-rust-clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check-rust-clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|