Simplify memory swap

[paulgb]

@rolyatmax caught this, it may have been useful at some point but it no longer is since we aren't doing anything with the result.

---

Important

Replace std::mem::swap with direct assignment in set_sender() in key_manager.rs.

• Refactor:
  • Replace std::mem::swap with direct assignment in set_sender() in key_manager.rs for handle update.

^{This description was created by for 7ff7225. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plane	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 10:22pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7ff7225 in 8 seconds

More details

• Looked at 21 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. plane/src/drone/key_manager.rs:134

• Draft comment:
  The change from std::mem::swap to direct assignment is appropriate and simplifies the code. This is more idiomatic since the result of GuardHandle::new is not used elsewhere.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The change from using std::mem::swap to direct assignment is appropriate since the result of GuardHandle::new is not used elsewhere. This simplifies the code and is more idiomatic.

Workflow ID: wflow_1T3g8Q4qYLDfjjhu

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.