Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux event loop hanging #1452

Closed
anastasiatimit opened this issue Jun 6, 2024 · 7 comments
Closed

Linux event loop hanging #1452

anastasiatimit opened this issue Jun 6, 2024 · 7 comments
Assignees
@bakpakin
Labels
bug This is not expected behavior, and needs fixing needs repro No repro yet provided

Comments

@anastasiatimit
Copy link

Can't upgrade janet version due to stream or event error, not sure, no error is thrown, just app can't finish loading files.
The app is built on alpine linux.

After some testing, noticed that this is the first commit that made the application unresponsive, I think src/core/ev.c change started to change the behaviour, as building next commit and replacing this file from the working commit solved the issue in next commit.

Do you have any suggestion please what to do?

Thank you
@bakpakin
Copy link
Member

bakpakin commented Jun 6, 2024

Hi @anastasiatimit, what version of Janet are you trying to run? Does trying the latest master fix the problem? There was a bug involving epoll that would sometimes miss connections that is only fixed on the latest master

@anastasiatimit
Copy link
Author

@bakpakin, yes, I tried master, but same issue persists

@bakpakin
Copy link
Member

bakpakin commented Jun 6, 2024 •
edited
Loading

In that case we need a repro for the bug. Not enough to go off of here yet.

@sogaiu sogaiu mentioned this issue Jun 7, 2024
Closed
@sogaiu
Copy link
Contributor

sogaiu commented Jun 7, 2024

Possibly related might be this issue filed at the spork repository.

@bakpakin bakpakin changed the title Linux Linux event loop hanging Jun 7, 2024
@bakpakin bakpakin added needs repro No repro yet provided bug This is not expected behavior, and needs fixing labels Jun 7, 2024
@bakpakin bakpakin self-assigned this Jun 7, 2024
bakpakin added a commit that referenced this issue Jun 7, 2024
@bakpakin
Address #1452 - Partial revert some changes from #1391
e2a8951 
This doesn't seem to reintroduce the original issue. There was
definitely some interplay with #1431

Doing git bisect landed me at commit
2f0c789 as the first bad commit for
issue #1452.
@bakpakin
Copy link
Member

bakpakin commented Jun 7, 2024

@anastasiatimit Please check the latest master and see if this fixes your problem

@anastasiatimit
Copy link
Author

@bakpakin yes, such a great catch, can't reproduce the issue anymore, thank you!

@sogaiu
Copy link
Contributor

sogaiu commented Jun 13, 2024

@anastasiatimit Great to hear things are working!

May be the issue can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bakpakin bakpakin

Labels
bug This is not expected behavior, and needs fixing needs repro No repro yet provided
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bakpakin @sogaiu @anastasiatimit