Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cicd #7

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: cicd #7

merged 1 commit into from
May 2, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Apr 26, 2024 •
edited
Loading

Make all builds work.
Packaging and e2e testing will be added in other PRs.

@vansangpfiev vansangpfiev force-pushed the fix-cicd branch 2 times, most recently from 4c3de01 to 1471822 Compare April 26, 2024 14:28
@vansangpfiev vansangpfiev requested a review from hiento09 May 2, 2024 00:46
@vansangpfiev vansangpfiev marked this pull request as ready for review May 2, 2024 00:46
hiento09
hiento09 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vansangpfiev vansangpfiev merged commit 478de13 into main May 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @hiento09 @sangjanai