From 8929bd302298eb6cf66bb4f0ef72bfd9dbec5023 Mon Sep 17 00:00:00 2001 From: Avasam Date: Thu, 22 Aug 2024 13:03:03 -0400 Subject: [PATCH 1/2] disable_error_code = import-untyped in mypy.ini --- mypy.ini | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mypy.ini b/mypy.ini index 83b0d15c..db1bc70a 100644 --- a/mypy.ini +++ b/mypy.ini @@ -10,5 +10,9 @@ enable_error_code = ignore-without-code # Support namespace packages per https://github.com/python/mypy/issues/14057 explicit_package_bases = True -# Disable overload-overlap due to many false-positives -disable_error_code = overload-overlap +disable_error_code = + # Disabled due to many false-positives + overload-overlap, + # Enable import-untyped if you'd like to be notified about using untyped dependencies or missing stubs packages + # You can leave it disabled if your package isn't publicly typed / `py.typed` + import-untyped, From 2c40a3d99a0dc5f27e9380cf7fccd6702630df99 Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Sun, 25 Aug 2024 04:39:41 -0400 Subject: [PATCH 2/2] Update wording in the comment. Use imperative voice and orient the comment to describe the setting more directly and give guidance on what to do about it. --- mypy.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mypy.ini b/mypy.ini index db1bc70a..b44b1fbb 100644 --- a/mypy.ini +++ b/mypy.ini @@ -13,6 +13,6 @@ explicit_package_bases = True disable_error_code = # Disabled due to many false-positives overload-overlap, - # Enable import-untyped if you'd like to be notified about using untyped dependencies or missing stubs packages - # You can leave it disabled if your package isn't publicly typed / `py.typed` + # Disable import-untyped to avoid widespread failures. Remove when safe or when + # specific exclusions supersede this broad setting. import-untyped,