From 6e34b20c2996cee7965804236246c930e5ed810f Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Mon, 23 Mar 2020 23:11:24 -0400 Subject: [PATCH] (clean): remove all references to --define (#636) - these have been commented out for a long time now - babel-plugin-transform-replace-expressions also isn't in the dependencies either - they were borrowed from microbundle afaik, but both support babelrc nowadays; I think these defines are better configured there than with flags anyway --- src/babelPluginTsdx.ts | 4 ---- src/createRollupConfig.ts | 1 - 2 files changed, 5 deletions(-) diff --git a/src/babelPluginTsdx.ts b/src/babelPluginTsdx.ts index cc5728d55..665731394 100644 --- a/src/babelPluginTsdx.ts +++ b/src/babelPluginTsdx.ts @@ -73,10 +73,6 @@ export const babelPluginTsdx = babelPlugin.custom(() => ({ name: 'babel-plugin-transform-rename-import', replacements, }, - isTruthy(customOptions.defines) && { - name: 'babel-plugin-transform-replace-expressions', - replace: customOptions.defines, - }, { name: 'babel-plugin-transform-async-to-promises', inlineHelpers: true, diff --git a/src/createRollupConfig.ts b/src/createRollupConfig.ts index 72df89656..eedc7dd5b 100644 --- a/src/createRollupConfig.ts +++ b/src/createRollupConfig.ts @@ -183,7 +183,6 @@ export async function createRollupConfig( targets: opts.target === 'node' ? { node: '8' } : undefined, extractErrors: opts.extractErrors, format: opts.format, - // defines: opts.defines, }, }), opts.env !== undefined &&