From ffdec2f3c4f48aa7f66c487e1181a57cad5bc695 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Wed, 29 Jan 2020 07:11:37 -0500 Subject: [PATCH] (remove): redundant/confusing tsconfig target in templates - tsconfig target is always overwritten to ESNext by TSDX, and then the rest of the transpilation is done by @babel/preset-env - having templates with target set gives the false impression that target can be freely configured - also remove from tests as it's unused there --- templates/basic/tsconfig.json | 1 - templates/react-with-storybook/tsconfig.json | 1 - templates/react/tsconfig.json | 1 - test/fixtures/build-default/tsconfig.json | 1 - test/fixtures/build-invalid/tsconfig.json | 1 - test/fixtures/build-withConfig/tsconfig.json | 3 +-- 6 files changed, 1 insertion(+), 7 deletions(-) diff --git a/templates/basic/tsconfig.json b/templates/basic/tsconfig.json index 286aa413b..0fbd5f582 100644 --- a/templates/basic/tsconfig.json +++ b/templates/basic/tsconfig.json @@ -1,7 +1,6 @@ { "include": ["src", "types", "test"], "compilerOptions": { - "target": "es5", "module": "esnext", "lib": ["dom", "esnext"], "importHelpers": true, diff --git a/templates/react-with-storybook/tsconfig.json b/templates/react-with-storybook/tsconfig.json index 88c634d9a..3eb378a0d 100644 --- a/templates/react-with-storybook/tsconfig.json +++ b/templates/react-with-storybook/tsconfig.json @@ -1,7 +1,6 @@ { "include": ["src", "types", "test"], "compilerOptions": { - "target": "es5", "module": "esnext", "lib": ["dom", "esnext"], "importHelpers": true, diff --git a/templates/react/tsconfig.json b/templates/react/tsconfig.json index 286aa413b..0fbd5f582 100644 --- a/templates/react/tsconfig.json +++ b/templates/react/tsconfig.json @@ -1,7 +1,6 @@ { "include": ["src", "types", "test"], "compilerOptions": { - "target": "es5", "module": "esnext", "lib": ["dom", "esnext"], "importHelpers": true, diff --git a/test/fixtures/build-default/tsconfig.json b/test/fixtures/build-default/tsconfig.json index eae0b2904..d8ff04c12 100644 --- a/test/fixtures/build-default/tsconfig.json +++ b/test/fixtures/build-default/tsconfig.json @@ -1,6 +1,5 @@ { "compilerOptions": { - "target": "es5", "module": "ESNext", "lib": ["dom", "esnext"], "declaration": true, diff --git a/test/fixtures/build-invalid/tsconfig.json b/test/fixtures/build-invalid/tsconfig.json index eae0b2904..d8ff04c12 100644 --- a/test/fixtures/build-invalid/tsconfig.json +++ b/test/fixtures/build-invalid/tsconfig.json @@ -1,6 +1,5 @@ { "compilerOptions": { - "target": "es5", "module": "ESNext", "lib": ["dom", "esnext"], "declaration": true, diff --git a/test/fixtures/build-withConfig/tsconfig.json b/test/fixtures/build-withConfig/tsconfig.json index ecb27d608..43e3ec95f 100644 --- a/test/fixtures/build-withConfig/tsconfig.json +++ b/test/fixtures/build-withConfig/tsconfig.json @@ -1,6 +1,5 @@ { "compilerOptions": { - "target": "es5", "module": "ESNext", "lib": ["dom", "esnext"], "declaration": true, @@ -26,4 +25,4 @@ "esModuleInterop": true }, "include": ["src", "types"], -} \ No newline at end of file +}