Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clarify the behaviour of lax.switch with vmap. #16335

Merged

Conversation

JoeyTeng
Copy link
Contributor

@JoeyTeng JoeyTeng commented Jun 9, 2023

This is in-line with PR #13589, also related to #8409

Add explanation: switch will be converted to select when transformed with vmap in doc.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Jun 14, 2023
@jakevdp jakevdp self-assigned this Jun 14, 2023
@soraros
Copy link

soraros commented Jun 14, 2023

@jakevdp Is mentioning XLA Ops still good, or is it better to point to StableHLO Ops?

@jakevdp
Copy link
Collaborator

jakevdp commented Jun 14, 2023

I think XLA ops are still fine, since XLA is the relevant compiler.

@copybara-service copybara-service bot merged commit 10e2b86 into jax-ml:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants