Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement jnp.linalg.multi_dot using opt_einsum #21115

Merged
merged 1 commit into from
May 7, 2024
Merged

Implement jnp.linalg.multi_dot using opt_einsum #21115

merged 1 commit into from
May 7, 2024
+97 −111

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented May 7, 2024

There's no reason to do this optimization ourselves when we already have opt_einsum as a dependency.

@jakevdp jakevdp self-assigned this May 7, 2024
@jakevdp jakevdp requested a review from hawkinsp May 7, 2024 20:40
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels May 7, 2024
@copybara-service copybara-service bot merged commit 78e10ee into jax-ml:main May 7, 2024
12 of 13 checks passed
@jakevdp jakevdp deleted the multi-dot branch May 7, 2024 21:34
@jakevdp jakevdp mentioned this pull request May 9, 2024
Merged
@dfm dfm mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkinsp hawkinsp hawkinsp approved these changes

Assignees

@jakevdp jakevdp

Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakevdp @hawkinsp