Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleFactory missing from the scanFor<>Files() methods #28

Closed
3 tasks done
jayasuryat opened this issue Aug 22, 2023 · 0 comments · Fixed by #37
Closed
3 tasks done

ModuleFactory missing from the scanFor<>Files() methods #28

jayasuryat opened this issue Aug 22, 2023 · 0 comments · Fixed by #37
Assignees
Labels
bug Something isn't working good-first-issue
Milestone

Comments

@jayasuryat
Copy link
Owner

jayasuryat commented Aug 22, 2023

ModuleFactory is missing from the scanFor<>Files() methods. It is currently only being used in the Module factory extension.

The intension was always to expose this in the scanFor<>Files() methods and have DefaultModuleFactory as a default value. Somehow I missed this in the earlier releases.


TODO

  • Take ModuleFactory as a param for all of the scanFor<>Files() methods with DefaultModuleFactory as the default value
  • Update tests to test if all the scanFor<>Files() methods are properly using the passed ModuleFactory
  • Dump and validate public API

This would be a backwards-source-compatible change as we are just adding a new param with default value, so all of the existing call-sites should work as is.

@jayasuryat jayasuryat assigned jayasuryat and unassigned jayasuryat Aug 22, 2023
@jayasuryat jayasuryat added the bug Something isn't working label Aug 22, 2023
@jayasuryat jayasuryat added this to the v0.7.0 milestone Aug 22, 2023
@jayasuryat jayasuryat self-assigned this Oct 11, 2023
jayasuryat added a commit that referenced this issue Oct 11, 2023
jayasuryat added a commit that referenced this issue Oct 11, 2023
@jayasuryat jayasuryat linked a pull request Oct 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant