From f1fb61c64b4bb54bcbc2aaacf4d7e2e57b91009c Mon Sep 17 00:00:00 2001 From: Jay Conrod Date: Wed, 27 Nov 2019 13:19:05 -0500 Subject: [PATCH] Remove //tests/legacy/cgo_library_root_dir Seems redundant with other tests. Updates #2285 --- .bazelci/presubmit.yml | 2 -- tests/legacy/cgo_library_root_dir/BUILD.bazel | 27 ------------------- tests/legacy/cgo_library_root_dir/cgo.go | 8 ------ tests/legacy/cgo_library_root_dir/cgo_test.go | 9 ------- tests/legacy/cgo_library_root_dir/foo.c | 1 - 5 files changed, 47 deletions(-) delete mode 100644 tests/legacy/cgo_library_root_dir/BUILD.bazel delete mode 100644 tests/legacy/cgo_library_root_dir/cgo.go delete mode 100644 tests/legacy/cgo_library_root_dir/cgo_test.go delete mode 100644 tests/legacy/cgo_library_root_dir/foo.c diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 5426644fdf..4b5b8e5ab4 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -178,7 +178,6 @@ platforms: - "-//tests/integration/googleapis:color_service_go_proto" - "-//tests/integration/googleapis:color_service_proto" - "-//tests/integration/googleapis:color_service_test" - - "-//tests/legacy/cgo_library_root_dir:cgo_library_root_dir" - "-//tests/legacy/examples/cgo/example_command:example_command_test" - "-//tests/legacy/examples/cgo/example_command:example_command_script" - "-//tests/legacy/examples/cgo/example_command:example_command" @@ -292,7 +291,6 @@ platforms: - "-//tests/core/stdlib:buildid_test" - "-//tests/examples/executable_name:executable_name" - "-//tests/integration/googleapis:color_service_test" - - "-//tests/legacy/cgo_library_root_dir:cgo_library_root_dir" - "-//tests/legacy/examples/cgo/example_command:example_command_test" - "-//tests/legacy/examples/cgo/example_command:example_command_script" - "-//tests/legacy/examples/cgo/example_command:example_command" diff --git a/tests/legacy/cgo_library_root_dir/BUILD.bazel b/tests/legacy/cgo_library_root_dir/BUILD.bazel deleted file mode 100644 index 8094f37599..0000000000 --- a/tests/legacy/cgo_library_root_dir/BUILD.bazel +++ /dev/null @@ -1,27 +0,0 @@ -load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") -load("@io_bazel_rules_go//tests:bazel_tests.bzl", "bazel_test") - -go_test( - name = "go_default_test", - size = "small", - srcs = ["cgo_test.go"], - embed = [":go_default_library"], - tags = ["manual"], -) - -go_library( - name = "go_default_library", - srcs = [ - "cgo.go", - "foo.c", - ], - cgo = True, - importpath = "github.com/bazelbuild/rules_go/tests/cgo_library_root_dir", - tags = ["manual"], -) - -bazel_test( - name = "cgo_library_root_dir", - command = "test", - targets = [":go_default_test"], -) diff --git a/tests/legacy/cgo_library_root_dir/cgo.go b/tests/legacy/cgo_library_root_dir/cgo.go deleted file mode 100644 index a3e3688565..0000000000 --- a/tests/legacy/cgo_library_root_dir/cgo.go +++ /dev/null @@ -1,8 +0,0 @@ -package cgo_library_root_dir - -/* -const int foo; -*/ -import "C" - -var Foo = int(C.foo) diff --git a/tests/legacy/cgo_library_root_dir/cgo_test.go b/tests/legacy/cgo_library_root_dir/cgo_test.go deleted file mode 100644 index a91b569ca8..0000000000 --- a/tests/legacy/cgo_library_root_dir/cgo_test.go +++ /dev/null @@ -1,9 +0,0 @@ -package cgo_library_root_dir - -import "testing" - -func TestFoo(t *testing.T) { - if got, want := Foo, 42; got != want { - t.Errorf("got %d; want %d", got, want) - } -} diff --git a/tests/legacy/cgo_library_root_dir/foo.c b/tests/legacy/cgo_library_root_dir/foo.c deleted file mode 100644 index eea8eec4a5..0000000000 --- a/tests/legacy/cgo_library_root_dir/foo.c +++ /dev/null @@ -1 +0,0 @@ -const int foo = 42;