fix: Keyboard event memory leak #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2024
* fix: Keyboard event memory leak * fix: add dist 816d76d
jaywcjlove
added a commit
that referenced
this pull request
Jan 13, 2024
|
@jaywcjlove thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：当绑定快捷键时会给元素添加keyup和keydown的事件，该事件一直没有被移除，即使元素上的快捷键都unbind了，也不会清除keyup和keydown事件，导致内存泄漏。
解决方案：在unbind时判断unbind的元素上是否还有快捷键，如果没有快捷键就移除该元素上的keyup和keydown事件
解决 #90 提到的内存泄漏问题
解决 #115 提到的在vue中使用引起的内存泄漏问题