feat: support mocker config in the command line #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaywcjlove
reviewed
Oct 27, 2020
packages/core/package.json
Outdated
| @@ -47,5 +47,8 @@ | |||
| "http-proxy": "1.18.1", | |||
| "local-ip-url": "1.0.3", | |||
| "path-to-regexp": "6.2.0" | |||
| }, | |||
| "devDependencies": { | |||
| "minimist": "^1.2.5" | |||
There was a problem hiding this comment.
- "devDependencies": {
- "minimist": "^1.2.5"
- }
+ "dependencies": {
+ "minimist": "^1.2.5"
....
+ }There was a problem hiding this comment.
Remove the devDependencies and move the miniimst into dependencies already.
|
Here, I have a question is that the unit test. Although I run the code build and debug through the use case follow the document, I cannot ensure the code changed runs is the same as the original code. Can I add some basic some unit tests in the project for the current file? |
|
@vanpipy sure, welcome to add unit tests. |
jaywcjlove
added a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #144