Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amazon] fixes for DE #86

Merged
merged 8 commits into from
Sep 26, 2024
Merged

[amazon] fixes for DE #86

merged 8 commits into from
Sep 26, 2024

Conversation

moritzj29
Copy link
Contributor

Hi, there have been some minor changes on Amazon DE webpage, which broke the invoice scraping. Also I fixed handling archived orders for non EN languages.

@Zburatorul
Copy link
Collaborator

@moritzj29 could you resolve the conflicts please?

@moritzj29
Copy link
Contributor Author

Sorry for the delayed response, unfortunately there have been issues again with the link extraction for hidden invoices (DE), which should be fixed now.

Regarding the conflict:

<<<<<<< dev/amazon
                (order_filter,), = self.wait_and_return(
                    lambda: self.find_visible_elements(By.XPATH, '//select[@name="timeFilter"]')
                )
=======
                order_filter, = self.wait_and_locate((By.CSS_SELECTOR, '#time-filter, #orderFilter'))
>>>>>>> master

#97 introduced getting the order filter by a CSS_SELECTOR. In my case, this does not work reliably in headless mode. I myself adjusted the existing XPATH to the updated page. I have no issues with XPATH, also in headless mode. Therefore I would argue for going with this original approach. Please let me know if you think otherwise.

@Zburatorul Zburatorul merged commit b2867f0 into jbms:master Sep 26, 2024
5 checks passed
@Zburatorul
Copy link
Collaborator

Tested. Works.

Zburatorul added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants